Create CodemodCommand Remove/Add Import helper functions#1432
Merged
frvnkliu merged 3 commits intoInstagram:mainfrom Dec 17, 2025
Merged
Create CodemodCommand Remove/Add Import helper functions#1432frvnkliu merged 3 commits intoInstagram:mainfrom
frvnkliu merged 3 commits intoInstagram:mainfrom
Conversation
Comment on lines
+72
to
+73
| obj: Optional[str] = None, | ||
| asname: Optional[str] = None, |
Contributor
There was a problem hiding this comment.
can we use the updated str | None syntax instead
Member
Author
There was a problem hiding this comment.
Just updated the commits!
bd06426 to
5a48ffd
Compare
…r's remove unused import functions in CodemodCommand
… add needed import functions in CodemodCommand
Add comprehensive tests for the new helper methods: - remove_unused_import - remove_unused_import_by_node - add_needed_import Tests cover simple cases, from imports, aliased imports, relative imports, and combined add/remove operations.
5a48ffd to
2824627
Compare
drinkmorewaterr
approved these changes
Dec 17, 2025
frvnkliu
added a commit
to frvnkliu/LibCST
that referenced
this pull request
Jan 9, 2026
) * Create helper functions to abstract away usage of RemoveImportsVisitor's remove unused import functions in CodemodCommand * Create helper functions to abstract away usage of AddImportsVisitor's add needed import functions in CodemodCommand * Add tests for CodemodCommand helper functions Add comprehensive tests for the new helper methods: - remove_unused_import - remove_unused_import_by_node - add_needed_import Tests cover simple cases, from imports, aliased imports, relative imports, and combined add/remove operations.
jorenham
pushed a commit
to jorenham/LibCST
that referenced
this pull request
Feb 3, 2026
) * Create helper functions to abstract away usage of RemoveImportsVisitor's remove unused import functions in CodemodCommand * Create helper functions to abstract away usage of AddImportsVisitor's add needed import functions in CodemodCommand * Add tests for CodemodCommand helper functions Add comprehensive tests for the new helper methods: - remove_unused_import - remove_unused_import_by_node - add_needed_import Tests cover simple cases, from imports, aliased imports, relative imports, and combined add/remove operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of the key features of the
CodemodCommandclass is that it abstracts away the final run ofAddImportsVisitorandRemoveImportsVisitorintransform_module(Code Source). However, currently developers still need to utilize the static functions:RemoveImportsVisitor.remove_unused_importRemoveImportsVisitor.remove_unused_import_by_nodeAddImportsVisitor.add_needed_importTo actually manage the import states in the
self.context: CodemodContext. I propose defining these three new instance functions on CodemodCommand:remove_unused_importremove_unused_import_by_nodeadd_needed_importThese new lightweight helper wrapper functions defined on
CodemodCommandwill help to hopefully completely abstract awayRemoveImportsVisitorandAddImportsVisitor.[Example] Remove + Add Imports
Before:
After:
Test Plan
Specific Unit Tests found in:
and can be run using
[IG][Meta] Would be nice to have this to lower barrier of entry for using
CodemodCommand.